#141680: "incorrect score display"
这个案件是关于哪方面的？
发生什么事? 请从下方选择
发生什么事? 请从下方选择
请检查是否已有同课题案件
若肯定，请「投票」给这桩案件。最高票的案件将「优先」处理！
| # | Status | Votes | Game | Type | Title | Last update |
|---|
细节描述
-
• 如果有的话，请将你在屏幕上所看到的错误信息粘贴出来.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• 请说明你当时想做什么，你做了什么，然后发生了什么
• 您正使用哪一款浏览器呢？
opera
-
• 请简明而精确地解释您的建议，以便让人明白您想表达的意思。
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• 您正使用哪一款浏览器呢？
opera
-
• 当你被封锁的时候，屏幕上出现了些什么呢？(空白的屏幕？部分游戏平台画面？错误的信息？)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• 您正使用哪一款浏览器呢？
opera
-
• 哪个规则没有被BGA的设计小组写进游戏里？
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• 在游戏回放中，是否有不符合游戏规则的地方？如果有的话，请问是在哪一步呢？
• 您正使用哪一款浏览器呢？
opera
-
• 你当时是想做哪个游戏行动？
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• 你在想做什么的时候，触发了这个游戏选项？
-
• 当你想这么做时，发生了什么事(错误信息，游戏状态信息，......)？
• 您正使用哪一款浏览器呢？
opera
-
• 请问这个问题发生在游戏的哪个阶段(当前的游戏说明是什么)？
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• 当你想进行一个游戏行动时，发生了什么事(错误信息，游戏状态信息，......)？
• 您正使用哪一款浏览器呢？
opera
-
• 请描述一下显示画面上面的问题。 如果你有这个系统漏洞发生时的屏幕截图(画质不要太差)，你可以使用Imgur.com来把它上传到网络，然后将链接复制/粘贴到这里来。
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• 您正使用哪一款浏览器呢？
opera
-
• 请简明而精确地解释您的建议，以便让人明白您想表达的意思。
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• 您正使用哪一款浏览器呢？
opera
案件历史
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
增加一些新内容到这篇报告
- 其他的游戏桌 ID / 移动 ID
- 按 F5 是否解决了这个问题？
- 问题是否发生了好几次？还是每次都发生？还是时好时坏？
- 如果你有这个系统漏洞发生时的屏幕截图(画质不要太差)，你可以使用Imgur.com来把它上传到网络，然后将链接复制/粘贴到这里来。
